feature: webhooks #8674
feature: webhooks #8674
Conversation
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8674 +/- ##
============================================
+ Coverage 30.91% 31.34% +0.43%
- Complexity 33734 34355 +621
============================================
Files 5404 5432 +28
Lines 380289 381645 +1356
Branches 55489 55655 +166
============================================
+ Hits 117550 119634 +2084
+ Misses 247104 246194 -910
- Partials 15635 15817 +182
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
Signed-off-by: Abhishek Kumar <[email protected]>
|
@blueorangutan package |
|
@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9818 |
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Signed-off-by: Abhishek Kumar <[email protected]>
|
Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9820 |
|
@blueorangutan package |
|
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9822 |
|
@blueorangutan test |
|
@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
[SF] Trillian Build Failed (tid-10391) |
|
@blueorangutan test |
|
@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-10394)
|
* feature: webhooks Documentation for apache/cloudstack#8674 * changes Signed-off-by: Abhishek Kumar <[email protected]> * changes Signed-off-by: Abhishek Kumar <[email protected]> * changes Signed-off-by: Abhishek Kumar <[email protected]> * Update source/adminguide/events/webhooks.rst * note regarding duplicate event deliveries Signed-off-by: Abhishek Kumar <[email protected]> * note on self-signed https payload url Signed-off-by: Abhishek Kumar <[email protected]> --------- Signed-off-by: Abhishek Kumar <[email protected]>
api/src/main/java/org/apache/cloudstack/api/command/admin/user/UpdateUserCmd.java
Show resolved
Hide resolved
api/src/main/java/org/apache/cloudstack/api/response/BucketResponse.java
Show resolved
Hide resolved
* api,server,ui: weebhoks feature Signed-off-by: Abhishek Kumar <[email protected]> * fix Signed-off-by: Abhishek Kumar <[email protected]> * fix Signed-off-by: Abhishek Kumar <[email protected]> * changes Signed-off-by: Abhishek Kumar <[email protected]> * registry of message busses * test bus Signed-off-by: Abhishek Kumar <[email protected]> * refactor Signed-off-by: Abhishek Kumar <[email protected]> * test Signed-off-by: Abhishek Kumar <[email protected]> * fix and refactor Signed-off-by: Abhishek Kumar <[email protected]> * changes for webhook dispatch history Signed-off-by: Abhishek Kumar <[email protected]> * changes, initial ui Signed-off-by: Abhishek Kumar <[email protected]> * improvements Signed-off-by: Abhishek Kumar <[email protected]> * changes for account webhook cleanup Signed-off-by: Abhishek Kumar <[email protected]> * fix remaining event bus usage Signed-off-by: Abhishek Kumar <[email protected]> * changes for testing webhook dispatch Signed-off-by: Abhishek Kumar <[email protected]> * wip Signed-off-by: Abhishek Kumar <[email protected]> * fix test Signed-off-by: Abhishek Kumar <[email protected]> * make element Signed-off-by: Abhishek Kumar <[email protected]> * missing Signed-off-by: Abhishek Kumar <[email protected]> * buid fix * fix lint Signed-off-by: Abhishek Kumar <[email protected]> * changes for project delete check Signed-off-by: Abhishek Kumar <[email protected]> * fix Signed-off-by: Abhishek Kumar <[email protected]> * add collapse in create Signed-off-by: Abhishek Kumar <[email protected]> * ui fix and refactor for eventditributor publish Signed-off-by: Abhishek Kumar <[email protected]> * update org.json and add json validation Signed-off-by: Abhishek Kumar <[email protected]> * schema fixes Signed-off-by: Abhishek Kumar <[email protected]> * wordings Signed-off-by: Abhishek Kumar <[email protected]> * ui: improve progress button Signed-off-by: Abhishek Kumar <[email protected]> * ui improvements Signed-off-by: Abhishek Kumar <[email protected]> * remove unrelated change Signed-off-by: Abhishek Kumar <[email protected]> * search and count Signed-off-by: Abhishek Kumar <[email protected]> * add payloadurl in info Signed-off-by: Abhishek Kumar <[email protected]> * positive progress Signed-off-by: Abhishek Kumar <[email protected]> * fix hmac key Signed-off-by: Abhishek Kumar <[email protected]> * create webhook form fixes Signed-off-by: Abhishek Kumar <[email protected]> * refactor, address feedback Signed-off-by: Abhishek Kumar <[email protected]> * indentation Signed-off-by: Abhishek Kumar <[email protected]> * fix filters Signed-off-by: Abhishek Kumar <[email protected]> * remove test eventbus Signed-off-by: Abhishek Kumar <[email protected]> * default scope be Local Signed-off-by: Abhishek Kumar <[email protected]> * add lifecycle smoke test Signed-off-by: Abhishek Kumar <[email protected]> * add test for webhook deliveries Signed-off-by: Abhishek Kumar <[email protected]> * refactor Signed-off-by: Abhishek Kumar <[email protected]> * fix lint Signed-off-by: Abhishek Kumar <[email protected]> * refactor - losgs and others Signed-off-by: Abhishek Kumar <[email protected]> * unit tests Signed-off-by: Abhishek Kumar <[email protected]> * fix lint Signed-off-by: Abhishek Kumar <[email protected]> * build fix Signed-off-by: Abhishek Kumar <[email protected]> * smoke test fix, log refactor Signed-off-by: Abhishek Kumar <[email protected]> * get bean from all components Signed-off-by: Abhishek Kumar <[email protected]> * ui: missing label Signed-off-by: Abhishek Kumar <[email protected]> * address review comments Signed-off-by: Abhishek Kumar <[email protected]> * add some more tests Signed-off-by: Abhishek Kumar <[email protected]> * lint Signed-off-by: Abhishek Kumar <[email protected]> * rename setting Signed-off-by: Abhishek Kumar <[email protected]> * upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 * fix test delivery layout Signed-off-by: Abhishek Kumar <[email protected]> * fix webhook secret display Signed-off-by: Abhishek Kumar <[email protected]> * add http to payloadurl when no scheme Signed-off-by: Abhishek Kumar <[email protected]> * allow removing secretkey for webhook Signed-off-by: Abhishek Kumar <[email protected]> * fix update sslverification Signed-off-by: Abhishek Kumar <[email protected]> * disallow same payload url for same account Signed-off-by: Abhishek Kumar <[email protected]> * fix delivery with url w/o scheme Signed-off-by: Abhishek Kumar <[email protected]> * api: listApis should return params based on caller Signed-off-by: Abhishek Kumar <[email protected]> * wip changes Signed-off-by: Abhishek Kumar <[email protected]> * Update engine/schema/src/main/resources/META-INF/db/schema-41900to42000.sql * remove unique constraint for now Constraint is present in Java code validations Signed-off-by: Abhishek Kumar <[email protected]> * fixes Signed-off-by: Abhishek Kumar <[email protected]> * ui: add option to delete multiple deliveries Signed-off-by: Abhishek Kumar <[email protected]> * add filter for deliveries, delete api start/endtime support Signed-off-by: Abhishek Kumar <[email protected]> * do not throw error when no deliveries removed Signed-off-by: Abhishek Kumar <[email protected]> * ui: fix deliveries table column sorting, time filter cancel Signed-off-by: Abhishek Kumar <[email protected]> * remove isDebugEnabled wrapping * merge fix Signed-off-by: Abhishek Kumar <[email protected]> --------- Signed-off-by: Abhishek Kumar <[email protected]> Co-authored-by: Daan Hoogland <[email protected]> Co-authored-by: Wei Zhou <[email protected]>
* feature: webhooks Documentation for apache/cloudstack#8674 * changes Signed-off-by: Abhishek Kumar <[email protected]> * changes Signed-off-by: Abhishek Kumar <[email protected]> * changes Signed-off-by: Abhishek Kumar <[email protected]> * Update source/adminguide/events/webhooks.rst * note regarding duplicate event deliveries Signed-off-by: Abhishek Kumar <[email protected]> * note on self-signed https payload url Signed-off-by: Abhishek Kumar <[email protected]> --------- Signed-off-by: Abhishek Kumar <[email protected]>
|
@shwstppr this is a great feature for us. |
|
@btzq I'm not sure if ACS currently publishes a separate event for router healthcheck fails but it does publish an event with type An example description of such event, |
|
@shwstppr under events, i only could find this:
But it seems to be under (Level = INFO) (Type = Health Check) |
|
@shwstppr I think thats pretty good for us, we just need to have an alert when there is a failing health check. Right now, we have to login in ACS every few minutes and check the UI. We dont have RabbitMQ/Kafka installed. |
|
@btzq that Type showing as Maybe test creating a Global webhook and try there |
|
I see, Thank you @shwstppr excited to test this! |
9 participants
Description
Feature spec: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Webhooks
Webhooks allow external services to be notified when certain events happen.
To implement and make Webhook work as an event bus, changes have been made to publish messages on multiple active message buses.
Fixes #6778
Documentation PR: apache/cloudstack-documentation#385
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?